Panel sidebar image drop to textarea field creating kirbytag broken?

bnomei · June 22, 2017, 11:14am

in 2.4.1 is i can not get dropping an image from the sidebar to create a image tag anymore (safari and firefox)? when was this removed? or did i break anything?

@jenstornell once did trackdown the code involved… maybe this helps?

texnixe · June 22, 2017, 4:44pm

Are you using any plugins that might somehow interfere? Do you have the same problem with a fresh Starterkit?

bnomei · June 23, 2017, 7:30am

silly me. why do i always forget to check with a clean installation.

yes, i do use plugins. upon closer inspection it seems @jenstornell 's headlinejump plugin is the culprit.

jenstornell · June 23, 2017, 8:56am

I have no computer access for a few days but if you want to experiment the script is not that long or complicated.

github.com

jenstornell/kirby-headline-jump/blob/master/fields/headlinejump/assets/js/script.js

(function($) {
	$.fn.headlinejump = function() {
		return this.each(function() {
			var field = $(this);
			var fieldname = 'headlinejump';

			if(field.data( fieldname )) {
				return true;
			} else {
				field.data( fieldname, true );
			}

			var li = '';

			$(document).find('.field-with-headline').each(function( index ) {
				var title = $(this).find('.hgroup-title').html();
				li += '<li class="headline-jump-item" data-count="' + index + '">' + title + '</li>';
			});

			if( li != '' ) {

This file has been truncated. show original

Thanks for the issue report and your latest donation.

texnixe · June 23, 2017, 9:07am

I did a quick test with a 2.4.1 Starterkit and the headline jump plugin and can’t reproduce the issue. Also, the javascript does not really look like it would interfere with the drag & drop functionality?

bnomei · June 23, 2017, 9:19am

if i remove the plugin from the blueprint the issue goes away in my setup. thats a pretty strong indicator imho. but i will do some more testing. thanks @texnixe for trying with a clean installation.

texnixe · June 23, 2017, 9:42am

Oh, sorry, I was being stupid (forgot to add the field ), you are right, it does not work.

jenstornell · July 3, 2017, 12:19pm

@bnomei @texnixe

I added a fix. The new version should work now.

https://github.com/jenstornell/kirby-headline-jump/commit/79d696b602e055d4e3d647f04a860a7b50604d73

bnomei · July 3, 2017, 12:30pm

it does. thanks. and some chars.

Topic		Replies	Views
Panel image textarea drop jQuery trigger Solved ✅	2	1195	April 28, 2016
Enable image drop on panelfield Solved ✅	6	2262	July 19, 2016
Using <textarea /> in content is wracking the panel Solved ✅	11	1016	February 23, 2017
Images on text hover (from textarea) Solved ✅	5	418	April 15, 2019
Ctrl-Z for file uploads & drag to text field Suggestions 💡	4	922	February 25, 2016

Panel sidebar image drop to textarea field creating kirbytag broken?

Related topics