Page->create() does not return object with correct template

bnomei · August 18, 2016, 10:31am

a ‘dashbox’ is a child (=subpage) of ‘dashboard’.
both template and blueprint files exist and are valid yml.
kirby version is 2.3.0.

i create a new page with an template like this…

// $dashboard is root folder to create stuff.
$newUriForDashbox = $dashboard->uri() . DS . $newUsername;
$dashbox = $dashboard->create($newUriForDashbox, 'dashbox', [
    'user' => $user->username(), 
    'title' => $newUsername,
    'erstelltam' => date('c'),
    'erstelltvon' => $user->username(),
    'erstelltvisitor' => visitor::ip().' '.visitor::userAgent(),
    'finalisiert' => false
]);
echo $dashbox->template(); // = default, but dashbox was expected

the file is created correctly, path and filename (matching template name).
but the returned object is not the one created, but an ‘default’ page.

when i get the object manually again after creating like above all is well.

$dashbox = $pages->find($newUriForDashbox);
echo $dashbox->template(); // = dashbox
echo $dashbox->intendedTemplate(); // = content of $newUsername (=foldername)

whats going wrong when calling create()?

texnixe · August 18, 2016, 10:45am

I think you should use the $pages->create() method instead of the static method $page->create():

$dashbord = page('dashboard');
$dashbox = $dashboard->children()->create($newUsername, 'dashbox', [
    'user' => $user->username(), 
    'title' => $newUsername,
    'erstelltam' => date('c'),
    'erstelltvon' => $user->username(),
    'erstelltvisitor' => visitor::ip().' '.visitor::userAgent(),
    'finalisiert' => false
]);
```

bnomei · August 18, 2016, 11:03am

resulting dashbox is still of template default.

texnixe · August 18, 2016, 11:20am

Yeah, you are right, this seems really weird. I just tested this and found that with one template I used, the correct template was shown, but with all other templates it failed, showing “default” instead.

While $dashboard->intendedTemplate() shows the uid, which is not correct either.

bnomei · August 18, 2016, 11:33am

i have 41 blueprints/templates. could this be an issue? like memorywise?

bnomei · August 18, 2016, 11:33am

most of my templates have a ‘-’ (minus) within their filename.

bnomei · August 18, 2016, 11:36am

maybe kirby->registry is somehow broken by my code? https://github.com/getkirby/kirby/blob/master/core/page.php#L1009

texnixe · August 18, 2016, 11:36am

I don’t think so, I tested this with about 12 - 18 blueprints/templates, none of which had any special characters in their filenames. But maybe we should test with a fresh starterkit first.

bnomei · August 18, 2016, 11:41am

i think i encountered something similar before. i did forget to create the template file and only had the blueprint. then the create function did not work either. could it be that i have a missing (check, seems not) or broken template/blueprint? my buleprints are (almost) valid yaml just check again. some contain a regex passage like this which is NOT (edited) accepted by yaml validators.

telefon:
  width: 1/3
  label: Telefon
  type: tel
  required: true
  help: Bitte geben Sie Telefon und Faxnummern komplett mit Vorwahl, jedoch ohne Sonderzeichen wie z.B. Klammern oder Punkte ein.
  validate:
    match: "/^\d[\d ]+\d$/"

texnixe · August 18, 2016, 11:45am

I just tested this in a fresh starterkit with the available blueprint/template pairs and it worked perfectly, so the question is why it does not work in the other cases, in the other project where I tested this first, all blueprint/template pairs were available as well and nothing special in yaml.

Have you tried without the validate option?

bnomei · August 18, 2016, 12:02pm

it did work before with the vaidate. today i just added two new templates/blueprints (with no regex) and now its broken. i checked my repo not much else changed. does kirby cache this ‘registry’ between session?

bnomei · August 18, 2016, 12:56pm

why does getting the template directly after creating it work with find() but not when using the page() function? page() is used for the return value of create(), right?

 // HERE: create page omitted then...
 $dashbox = kirby()->site()->page($newUriForDashbox);
 echo '1:'.$dashbox->template(); // = default, which is wrong. should be 'dashbox'
 $dashbox = $pages->find($newUriForDashbox);
 echo '2:'.$dashbox->template(); // = dashbox, which is right

texnixe · August 18, 2016, 1:05pm

But you said above, that even then the $page->intendedTemplate() method does not output the intended template but the page uid? While it should output the name of the text file, not the foldername.

I think the problem must be something else, as it all works perfectly as it should with a fresh starterkit. Only I have no idea at the moment, what could be causing this issue. Maybe @lukasbestle to the rescue?

bnomei · August 18, 2016, 1:09pm

mabe because of this?

github.com

getkirby/kirby/blob/master/core/page.php#L1100


      return $this->_templateFile('default');
    } else {
      return $this->kirby->registry->get('template', 'default');
    }
  }
}


/**
 * Additional data, which will be passed to the template
 *
 * @return array
 */
public function templateData() {
  return array();
}


/**
 * Returns the name of the content text file / intended template
 * So even if there's no such template it will return the intended name.
 *
 * @return string

becauses its called here:

github.com

getkirby/kirby/blob/master/core/page.php#L1161


      call($headers, $this);
    }


  } else if($this->isErrorPage()) {
    header::notfound();
  }


  // send the header of the representation
  if($representation = $this->representation()) {
    if($mime = f::extensionToMime($representation)) header::type($mime);
  }


}


/**
 * Returns the root for the content file
 *
 * @return string
 */
public function textfile($template = null) {
  if(is_null($template)) $template = $this->intendedTemplate();

texnixe · August 18, 2016, 1:14pm

No, this is the page method:

/**
   * Returns the name of the content text file / intended template
   * So even if there's no such template it will return the intended name.
   *
   * @return string
   */
  public function intendedTemplate() {
    if(isset($this->cache['intendedTemplate'])) return $this->cache['intendedTemplate'];
    return $this->cache['intendedTemplate'] = $this->content()->exists() ? $this->content()->name() : 'default';
  }

And the text files do get named correctly …

bnomei · August 18, 2016, 1:22pm

using children()->create() calls static page::create, right?

github.com

getkirby/kirby/blob/master/core/children.php#L41


}


/**
 * Creates a new subpage
 *
 * @param string $uid
 * @param string $template
 * @param array $data
 */
public function create($uid, $template, $data = array()) {
  $page = page::create($this->page->id() . '/' . $uid, $template, $data);
  $this->data[$page->id()] = $page;
  return $page;
}


/**
 * Returns the parent page
 *
 * @return Page
 */
public function page() {

about the intendedTemplate, maybe cache need refresh after page create?

github.com

getkirby/kirby/blob/master/core/page.php#L724


}




/**
 * Returns the content object for this page
 *
 * @return Content
 */
public function content() {


  if(isset($this->cache['content'])) {
    return $this->cache['content'];
  } else {
    $inventory = $this->inventory();
    return $this->cache['content'] = new Content($this, $this->root() . DS . array_shift($inventory['content']));
  }


}


/**
 * Returns the title for this page and

Topic		Replies	Views
YAML data from page object Solved ✅	5	614	September 20, 2017
`$parent->createChild()` returns `null` instead of a new `Page` object Solved ✅	7	390	April 25, 2021
$page->create Kirby 3 change Solved ✅	8	607	July 3, 2019
$page->children()->create() in Kirby 3 Solved ✅	6	385	April 28, 2019
Performance - createChild vs pageObject Kirby 3 performance	3	716	June 6, 2020

Page->create() does not return object with correct template

Related Topics