Hyphen appearing before filename in text file

Kirby 3 Solved ✅
1

I’m updating my site from Kirby 2 to 3, and I’ve run into a problem. I have several image fields for main page image, page background and so on. They all work in that I can choose a page image and the filename gets added to the plaintext file for the page.

Thing is, when I edit a page Kirby adds a '- ’ (a dash and a space) before the filename. There didn’t used to be, and it’s breaking my templates. I’ve tried ‘$page->bgimage()’ and ‘$page->bgimage()->filename()’ (bgimage is one of the fieldnames) and nothing gets returned. If I remove the hyphen manually, it all works again.

Before:

img_0635.jpg

After:

- img_0635.jpg

What am I missing? Is that hyphen supposed to be there, and why? Also, why does it break the above functions?

Edit: in my blueprint I have this kind of set up for each image:

  background:
    label: Body background image
    type: files 
    multiple: false
    query: page.images
    width: 1/2

Thanks in advance!

1 Like
2

K3 store files in yaml format, after all, the field can store one or multiple files. You can still get the image object using the toFile() method like in K2:

if($image = $page->background()->toFile()):
  echo $image->url();
endif

What was the code you used before to fetch the images?

3

Thanks for replying! I was using that before, and kept getting PHP errors. Right now if I try that on my main template it returns the filename with the hyphen “- img_0635.jpg” and on my header snippet where I put in a background image I get a fatal-looking PHP error. Screenshot from debug:

03
Screenshot 2019-01-27 at 18.24.03.png1204×142 25.4 KB

(cover is the fieldname here)

4

Don’t know what’s happening on your side, but I just tested this in a project I’m converting to Kirby 3 and it works as expected.

Are you calling this code in a loop where not all images have the field filled in?

I don’t get enough context from your code snippet, but the way you coded that is not recommended anyway, because you should never ever call a class method (like url() in this case), without making sure you got an object to call it on. So either use an if statement like above or a ternary operator:

<?php dump(($image = $page->cover()->toFile()) ? $image->url(): null) ?>
1 Like
5

Thanks! I’ll give that a go, I realise my mistake now you’ve pointed it out - I’m checking for the existence of the wrong field! I’ll check it again tomorrow.

The other page was still returning the hyphen as part of the file name, I’ll post the chunk of code in the morning. Thanks for your help.

6

Hello! Thanks for your help. Turns out I made quite a few of the same mistake, and now everything works. :+1:

Thanks again!