Sub-pages and isChildOf()

bntwmrt · October 28, 2019, 6:16pm

Hi,

I’ve got this folders :

    1_informations 
       1_contact
       2_about
    2_images
       1_item_1
       2_item_2

At http://localhost/images/item_1
$page->isChildOf('informations') is true
page('informations')->isOpen() is false

Something wrong ?
(I just make a navigation with sub-pages link visibles if it’s the same father)

texnixe · October 28, 2019, 7:55pm

That doesn’t make sense. It should return false in this case, but the method always returns true no matter what you pass to it.

The result of the second statement is correct.

I created an issue on GitHub for the isChildOf() method:

github.com/getkirby/kirby

isChildOf() method always returns `true`

opened 08:11PM - 28 Oct 19 UTC

closed 08:33PM - 29 Oct 19 UTC

texnixe

type: bug 🐛 difficulty: easy 🤩

**Describe the bug** Whatever you pass to the `isChildMethod()` it always ret…urns true. Let's say you are in the Starterkit and add the following code in the `note.php`template: ``` var_dump($page->isChildOf('notes')); ``` rightly returns `true`, but ``` var_dump($page->isChildOf('photography')); ``` falsely also returns true. **Expected behavior** The method should create a page object from a string if a string is passed and then compare the parent to that the given page or the page created from the string. **Kirby Version** 3.0.0-rc-1

texnixe · October 28, 2019, 11:45pm

If you need more help, please post your code and what exactly you are trying to achieve.

isOpen() returns true if either the current page is active or a child page.

bntwmrt · October 29, 2019, 8:55am

It’s OK just like to understand the code