Recursion error when creating virtual page

The CMS Questions
1

We have a page that run in Kirby 3.8 with virtual pages that are connected to database after following this recipe: Content from a database | Kirby CMS

We want run this with Kirby 4 and got a problem when creating a page in panel:
Error: Xdebug has detected a possible infinite loop, and aborted your script with a stack depth of ‘1000’ frames

Collection.php
line: 470

We can see that the error happens before fireing page methods like ‘create’ or ‘writeContent’ so we assume that the error is related to changings in Kirby 4.
Nevertheless displaying and saving our already created pages work fine so far in Kirby 4.

Thanks in advance!
Mattes

2

Hm, is there more information like a stack trace? Line 470 in the Collections.php class refers to the get() method which doesn’t really help.

3

Yes here wen got a screenshot from stacktrace!

Bildschirmfoto 2024-04-01 um 19.46.32
Bildschirmfoto 2024-04-01 um 19.46.321162×864 164 KB

4

Ok, so you have a multi-language site and the issue seems to happen there somewhere. From which language were you creating the new page, from the default or non-default language?

5

From default. Same error in the other lang.

6

Could you post your isDraft() method from virtual-page.php? Seems to run into this time and again

7

public function isDraft(): bool
{
return in_array($this->content()->kirby_status(), [‘listed’, ‘unlisted’]) === false;
}

9

Ok ‘$this->content()’ is triggering the recursion.
By hard returning ‘false’ page creation completes. Any guess how we can circumvent this? :slight_smile:

10

You could probably work around the issue by not having a isDraft() method. Instead, manipulate the $this->isDraft variable in the model constructor.

	public function __construct(array $props)
	{
		parent::__construct($props);

		if(!isset($props['isDraft'])) {
			$this->isDraft = !in_array($props['content']['kirby_status'] ?? '', ['listed', 'unlisted']);
		}
	}
11

Works perfectly! Thanks!