Page hasChildren but neither prev nor next?

Kirby 2 Solved ✅
1

Hi folks,

maybe you can help me in finding out what I am overlooking. I am trying to put together the previous sibling and next sibling if they exist. However, I am failing…

  if($page->hasSiblings()) {
      $items[] = [
        'url'   => $prev = $page->prev() ? $prev->url() : null,
        'label' => '<i class="fa fa-arrow-left"></i>',
        'class' => 'sibling' . ($prev ?: ' sibling--empty')
      ];

      $items[] = [
        'url'   => $next = $page->next() ? $next->url() : null,
        'label' => '<i class="fa fa-arrow-right"></i>',
        'class' => 'sibling' . ($next ?: ' sibling--empty')
      ];
    }

Even though the script enters the if-condition (so it hasSiblings… and yes it does), prev() as well as next() returning NULL. Shouldn’t at least one return a sibling, if hasSiblings() is true?

2

Yes, it should and a quick test revealed that the code works as expected as well (apart from the class assignment):

'class' => 'sibling' . ($prev ? '': ' sibling--empty')
3 
($prev ?: ' sibling--empty')

works as shorthand :wink:

In my fresh starterkit the code does not work as expected… but then I just realized, there isn’t a hasSiblings() :expressionless:

4

That’s what I guessed, but this is the result I get from the shorthand:

Array
(
    [0] => Array
        (
            [url] => http://localhost/kirby241
            [label] => 
            [class] => siblinghttp://localhost/kirby241
        )

    [1] => Array
        (
            [url] => 
            [label] => 
            [class] => sibling sibling--empty
        )

)
5

Ah right, good call! Thanks

6

Haha, right :blush:! Then

if($page->siblings(false)->count()) {
}

or create a custom hasSiblings method.

7

Created a custom page method :smiley:
And I found the real problem, why next() would only return NULL - I loaded $page with the page class of the panel – somehow those methods don’t work well with the panel $page. Forced it to be based on the normal Kirby page class and it works :slight_smile: