$oldPage in hooks doesn't return previous version of the page

Kirby 2 Issues šŸ›
#1

Add following in a hook:

kirby()->hook('panel.page.*', function($page, $oldPage = null) {
    error_log($page->title()->value());
    error_log($oldPage->title()->value());
});

When you update the title value (via the panel) you should see the new value first, followed by the previous value thereafter in the error log.

This is not the case on my install. What am i doing wrong?

Page update hook before content is written?
#2

This is a known issue: https://github.com/getkirby/panel/issues/1025

#3

Ouch. Did you find a way to work around this @thguenther?

As I experience it, $oldPage never seems to work in the hooks. A pretty nasty bug if you ask me?

#4

$oldPage used to work, though, as far as I remember. Need to look into this. Otherwise, we have to create a new issue on GitHub.

#5

@texnixe this seemed to work with a new starterkit, so I investigated this a bit further and come to the conclusion that this whole $oldPage functionality breaks the moment you add a field of the type ā€œimageā€ to the blueprint.

The ā€œselect fieldā€ (upon the image field extends) works perfectly, so the problem has to be inside the image field somewhere. Could you help me find a way around this problem now?

Thanks!

How to check if links to related pages are still valid
#6

@bvdputte Thanks for investigating this further. I just didnā€™t get round to looking into this, currently preparing to move flat this Saturday, so very little time, unfortunately. Iā€™ll try to look into this as soon as possible. In the meantime, could you please create an issue on GitHub, as this seems to be a bug that is different from the one @thguenther linked to.

#7

Thanks, have fun moving into your new place!
I have added an issue to the panel on GitHub (I hope that this is the correct place).

If anyone can help me working around this in the meantime, that would be awesome! ā€” thx

#8

Hm, I tested this with image field and panel.page.update hook and couldnā€™t reproduce the issue.

#9

How about using this:

kirby()->hook('panel.page.*', function($page, $oldPage = null) {

#10

Yes, I ran your code from the first post as well without any issues. The hook is triggered and if I change the title, it logs two different titles.

#11

Try again in a multilingual setup please?

I have this in my config:

// Languages
c::set('languages', array(
  array(
    'code'    => 'en',
    'name'    => 'English',
    'default' => true,
    'locale'  => 'en_US',
    'url'     => '/en',
),
  array(
    'code'    => 'nl',
    'name'    => 'Nederlands',
    'locale'  => 'nl_BE',
    'url'     => '/nl',
  ),
  array(
    'code'    => 'fr',
    'name'    => 'FranƧais',
    'locale'  => 'fr_BE',
    'url'     => '/fr',
  ),
  array(
    'code'    => 'de',
    'name'    => 'Deutsch',
    'locale'  => 'de_de',
    'url'     => '/de',
)
));
#12

In a multi-lang starter kit, I get this result: With an image selected in the image field, the hook is triggered but new and old title stay the same. With no image selected, the hook works as expected-

#13

Yes, I can confirm this behaviour.

So, basically, when you

  • have a multilingual setup
  • use the image field
  • have an image selected in that image field

$oldPage in hooks is broken.

#14

Yes, exactly like this.

#15

@lukasbestle, any chance you can take a look at this and help me out? Thanks!

1 Like
#16

I have seen your GitHub issue and will be taking a look at it for the next release. It needs more investigation. :slight_smile:

1 Like
#17

Thx @lukasbestle, I canā€™t wait :see_no_evil: