File URLs change when pages are moved or made invisible

[texnixe]

@anon77445132

I think, we want NOT to use the sort numbers…

I’m well aware of that, but you have to look at how links are usually generated to be able to find a solution.

[texnixe]

@PaulMorel: Let me know if this works for you, then we can close the GitHub issue again and wait for a native method to get a permanent URL.

As a file method:

<?php

file::$methods['permanentUrl'] = function($file) {
  return site()->url() . DS . $file->page()->id() . DS . $file->filename();
};

[PaulMorel]

@texnixe

This should work:

<? $image = $page->images()->first() ?>
<a href=“<?= $site->url() . DS . $page->id() . DS . $image->filename() ?>”>link to image</a>

It creates the link without language code and without the URL key, in the same way the standard, numbered image link is created, only without the content folder and without the numbers.

This causes a error 500 on the server and Kirby seems to display a JSON response of the error.

{"status":"error","message":"Invalid route or request method"}

@texnixe

@PaulMorel: Let me know if this works for you, then we can close the GitHub issue again and wait for a native method to get a permanent URL.

As a file method:

<?php

file::$methods[‘permanentUrl’] = function($file) {
return site()->url() . DS . $file->page()->id() . DS . $file->filename();
};

I get an error 500 served by the server, not Kirby.

[texnixe]

Do you get the error when clicking such a link or just from adding the method as a plugin?

[PaulMorel]

While clicking for the former and while adding the method for the latter.

Edit: my bad, there was a typo.

[texnixe]

I just added the file method in a new file “methods.php” and saved that in the plugins folder, that’s all (/site/plugins/methods.php)

[PaulMorel]

My bad, there was a typo in the file.

I still get a Kirby route error though. From what I can see it’s because neither urls have the language codes.

In my case, it works if you do it like this though.

file::$methods['permanentUrl'] = function($file) {
  return site()->url() . DS . site()->language()->code() . DS . $file->page()->id() . DS . $file->filename();
};

Not ideal, but it works.

[fvsch]

Note that the DS constant is not great here. You won’t have a problem on a Linux server, but for URLs you should just use /.

file::$methods['permanentUrl'] = function($file) {
  $site = $file->site();
  $lang = $site->multilang() ? $site->language()->code() . '/' : '';
  return $site->url() . '/' . $lang . $file->page()->id() . '/' . $file->filename();
};