Disable Thumbnail deleteion on file upload

zvaehn · April 10, 2017, 3:13pm

Hey,

i wondered that already created thumbnails got lost after a file has been changed in the panel.
I found this line:

getkirby/panel/blob/master/app/src/panel/models/page/uploader.php#L68


    $file->createMeta(false);      
  } catch(Exception $e) {
    // don't react on meta errors
    // the meta file can still be generated later
  }


  // make sure that the file is being marked as updated
  touch($file->root());


  kirby()->trigger($event, $file);          


}


public function replace() {


  $file   = $this->file;    
  $upload = new Upload($file->root(), array(
    'overwrite' => true,
    'accept' => function($upload) use($file) {
      if($upload->mime() != $file->mime()) {
        throw new Error(l('files.replace.error.type'));

Is there a possibility to disable this?
I dont want to hack in the kirby core because i plan to update kirby frequently.

Best,
Sven

thguenther · April 10, 2017, 4:03pm

This issue is fixed in the develop branch: https://github.com/getkirby/panel/issues/971#issuecomment-280028909

zvaehn · April 10, 2017, 4:15pm

ah, thank you! Can’t wait to get it live.

Topic		Replies	Views
An issue about thumbnails Solved ✅	14	2198	February 25, 2017
Thumbnail on upload - Keep the original and the generated image Questions 🤔 panel	0	377	December 11, 2018
Rename files on upload only working partly Kirby 3 plugin	15	644	July 23, 2021
Thumbnails not showing in panel Questions 🤔 panel	12	1009	February 26, 2018
Duplicate image and compress it automatically via panel upload?	19	499	October 26, 2021

Disable Thumbnail deleteion on file upload

Related Topics