Extending trait FileFoundation::isResizable

Kirby 3 Questions 🤔
1

Hey, I’m working with image formats currently not supported by mentioned function + F::isViewable - could I extend those using a plugin?

Thanks!
S1SYPHOS

2

Where did you find F::isResizable()?

3

I am deeply sorry, I meant this:

4

Since being resizable or not depends largely on the thumb driver … why should Kirby set this in stone?

@texnixe It’s just that I don’t want to live with a custom Kirby version from now on :wink:

5

That makes sense!

I don’t know why this is hardcoded. What sort of files do you want to resize? If you use your custom thumb component, it won’t have to check if a file is resizable like the Kirby native component does.

Having said that, if I knew how to easily monkey patch this method, I’d tell you.

6

I find it very convenient letting Kirby handle thumbs and just telling it to do it with my thumb driver (being added to Darkroom::$types and enabled if ‚thumbs.driver‘ = mydriver), also I don’t want to break other plugins, that’s why I decided to leave the thumbs component untouched.

Only thing is, as I said, this only works if I tell Kirby that my file formats are resizable … I’ll be happy to provide the necessary changes via PR for the next patch release - nothing breaks if I add AVIF (or even HEIC, JP2 or stuff like that) what do you think?

7

Sure, this hard-coded stuff should at least be extendable, I think.

8

For future reference: Nolt feedback and GitHub PR.