Commentions break in 3.5?

[Ndugu]

Whoops\Exception\ErrorException thrown with message “Required parameter $filename follows optional parameter $entry”

#18 Whoops\Exception\ErrorException in /Users/Ndugu/Sites/Projekt Websites/muspaeds-1-update/site/plugins/kirby3-commentions/lib/Storage.php:106
#17 Whoops\Run:handleError in /Users/Ndugu/Sites/Projekt Websites/muspaeds-1-update/kirby/config/helpers.php:514
#16 include in /Users/Ndugu/Sites/Projekt Websites/muspaeds-1-update/kirby/config/helpers.php:514
#15 {closure} in /Users/Ndugu/Sites/Projekt Websites/muspaeds-1-update/site/plugins/kirby3-commentions/lib/Commentions.php:394
#14 sgkirby\Commentions\Commentions:get in /Users/Ndugu/Sites/Projekt Websites/muspaeds-1-update/site/plugins/kirby3-commentions/index.php:102
#13 Kirby\Cms\Page:{closure} in [internal]:0
#12 Closure:call in /Users/Ndugu/Sites/Projekt Websites/muspaeds-1-update/kirby/src/Cms/HasMethods.php:43
#11 Kirby\Cms\Page:callMethod in /Users/Ndugu/Sites/Projekt Websites/muspaeds-1-update/kirby/src/Cms/Page.php:169
#10 Kirby\Cms\Page:__call in /Users/Ndugu/Sites/Projekt Websites/muspaeds-1-update/site/plugins/kirby3-commentions/lib/Frontend.php:64
#9 sgkirby\Commentions\Frontend:render in /Users/Ndugu/Sites/Projekt Websites/muspaeds-1-update/site/plugins/kirby3-commentions/helpers.php:7
#8 commentions in /Users/Ndugu/Sites/Projekt Websites/muspaeds-1-update/site/templates/blogpost.php:46
#7 include in /Users/Ndugu/Sites/Projekt Websites/muspaeds-1-update/kirby/src/Toolkit/F.php:403
#6 Kirby\Toolkit\F:loadIsolated in /Users/Ndugu/Sites/Projekt Websites/muspaeds-1-update/kirby/src/Toolkit/F.php:380
#5 Kirby\Toolkit\F:load in /Users/Ndugu/Sites/Projekt Websites/muspaeds-1-update/kirby/src/Toolkit/Tpl.php:35
#4 Kirby\Toolkit\Tpl:load in /Users/Ndugu/Sites/Projekt Websites/muspaeds-1-update/kirby/src/Cms/Template.php:167
#3 Kirby\Cms\Template:render in /Users/Ndugu/Sites/Projekt Websites/muspaeds-1-update/kirby/src/Cms/Page.php:1172
#2 Kirby\Cms\Page:render in /Users/Ndugu/Sites/Projekt Websites/muspaeds-1-update/kirby/src/Cms/App.php:686
#1 Kirby\Cms\App:io in /Users/Ndugu/Sites/Projekt Websites/muspaeds-1-update/kirby/src/Cms/App.php:1039
#0 Kirby\Cms\App:render in /Users/Ndugu/Sites/Projekt Websites/muspaeds-1-update/index.php:5```

[sebastiangreger]

Commentions should work fine with 3.5, but has not yet been tested/adapted for compatibility with PHP 8 (which above deprecation notice stems from) due to limited resources.

I just added a note to the Readme that PHP 8 is not officially supported by the plugin, but to possibly address the issue you raised I committed a quickfix of the /site/plugins/kirby3-commentions/lib/Storage.php file (direct link) in case you want to replace it manually for the time being.

In case you are going to apply above quickfix and subsequently get Commentions to run with or without issues on PHP 8, any feedback/hints/submissions are greatly appreciated to speed up our work …here or on Github issue #91

[Ndugu]

Oh of course (facepalm) - PHP 8:

Quick fix works!

Thank you very much!

[sebastiangreger]

@Ndugu

Quick fix works!

That’s great to hear – thanks for reporting back!